-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't install on Win 7 64 bits (can't download jpegtran.exe) #54
Comments
Trying jpegtran-bin@2.0.1 and jpegtran-bin@2.0.0 also have the same problem. 1.0.2 and 1.0.1 don't seem to work also. 1.0.0 works correctly downloading the binary file and copying it to vendor folder. So I'm guessing it has something to do with this: 1a6d1a2 Maybe something to do with windows permissions on how to download/copy .exe to the right folder or something like that? |
OK, I can confirm the problem has something to do with bin-build / bin-wrapper.
For example by using this npm-shrinkwrap.json: https://gist.github.com/pjfsilva/19e305be92270f38bc6e Everything works correctly with jpegtran-bin@2.0.2 so it seems the problem is on that libraries. |
👍 also unable to install on Win7 x64 with same error |
Same issue, but Win8.1 x64. :( Frustrating. |
same here, win7 x64
|
Hey @kevva, The installs for Windows are screwing it up because it needs two files --- all other OS's had just one file, hence no array. So in the download module, done() was being called after the first iteration (so whatever element is last in the array was the file actually downloaded). Line 148 in index.js |
I couldn't find an elegant solution to this sadly, but it's definitely the problem. Good luck! |
yikes. 👍 |
👍 |
2 similar comments
+1 |
+1 |
+1 (Windows 8.1 64bit) |
We've now had to remove gulp-imagemin from our process due to this, a pretty painful issue |
The same error on Windows 7 x64 :/ ‼ jpegtran pre-build test failed
i compiling from source
× Error: Command failed: '.' is not recognized as an internal or external comm |
👍 |
@kevva, Is there a fix on the way? |
download the last release as zip and copy the files to:
|
@dingdreher that worked for me, yay! |
Just to expand on what @dingdreher has posted. The main problem seems to be that the jpegtran.exe is not copied into the jpegtran-bin/vendor folder (just the libjpeg-62.dll file). What I did to get grunt-imagemin to work was save the vendor/jpegtran.exe in this repo to my jpegtran/vendor/ folder (this is considering that you are using the latest version of jpegtran-bin). Where I installed the jpegtran.exe How I found out where I needed to install (this output occurs when attempting to install jpegtran-bin. |
A proper fix would be preferable, of course. |
None of the listed solutions are working in my instance on Win 8.1 (x64). I've tried the solution provided by @pjfsilva by downgrading the following
Also, downloading the latest files and copying to the |
This worked for me: grabbed the 2.0.2 ZIP file from https://github.com/imagemin/jpegtran-bin/releases, then (using WinRAR or similar) navigated to |
@tedyoung Your solution works for me as well. |
tedyoung +1 |
tedyoung +1 |
@tedyoung Help for me on Win 8.1 x64 |
@tedyoung this crutch work as well. |
@artemmedvedev have you tried tedyoung's solution? did you get the same error? |
@avif yes, I had the same problem, but when I copy and replace two files problem was fixed |
Hi, everyone. I confirmed the issue and created PRs to fix it. kevva/download#43 kevva/bin-wrapper#33 @kevva @sindresorhus Please review them. |
I'm guessing that no word from the authors for nearly three weeks means they're too busy to fix it, so what's next? This is a part of Web Starter Kit, so it has some major implications. |
@pjfsilva it might help if you change the title to something like "Doesn't download jpegtran on all versions of Windows" so that this issue won't be viewed (and then dismissed) as an edge-case. |
@kevva @sindresorhus Could you give me write access for jpegtran-bin and imagemin-jpegtran npm package? |
@shinn done |
@sindresorhus thanks |
bin-wrapper has been updated so jpegtran-bin now works fine on Windows, I think. Could anyone reinstall jpegtran-bin, test it and tell us whether it works or not? (I'm not a Windows user) |
@shinnn confirmed on windows 7. Both files are downloaded. Thanks! |
OK, closing this issue since imagemin-jpegtran passed the test on AppVeyor and the actual Windows user @vweevers confirmed that it works. @pjfsilva @jaylinski @brih @dingdreher @jerome-nelson @kyleva @tedyoung
|
I'm trying to install jpegtran-bin by doing:
npm cache clean -f
npm install jpegtran-bin
The error I get is:
Checking my vendor folder it seems the file win/x64/jpegtran.exe isn't downloaded, I only have "libjpeg-62.dll" but I can't see any error even using -ddd switch. I've disabled antivirus and stuff like that and I tried over 2 networks with no luck...
Is there anything I can do to get more log or understand this better?
The text was updated successfully, but these errors were encountered: