-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommended_versions #264
base: main
Are you sure you want to change the base?
Conversation
2d83c4c
to
982fe62
Compare
TODO: Bump recommended scijava-search version to include scijava/scijava-search#30 |
982fe62
to
5dd4fb4
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 88.51% 88.62% +0.11%
==========================================
Files 53 53
Lines 4912 4942 +30
==========================================
+ Hits 4348 4380 +32
+ Misses 564 562 -2
☔ View full report in Codecov by Sentry. |
While this works, it'd be cool to get new versions of imagej-ops and scijava-search to pin here, so that we can get imagej/imagej-ops#651 and scijava/scijava-search#30 pinned as "recommended minimums". Pinging @hinerm. |
This enables us to suggest users upgrade their versions without forcing them to do so.
5dd4fb4
to
89032c4
Compare
a59163a
to
c0a9094
Compare
Since imagej2 has no minimum, we also have to add a bit of framework for recommended versions that AREN'T minimum versions
c0a9094
to
8a71ad8
Compare
I added on a commit here to recommend ImageJ2/Fiji 2.10.0, so this PR will also close #289 |
This enables us to suggest users upgrade their versions without forcing them to do so.
In this way, we allow users to upgrade their napari-imagej package without updating their ImageJ, but also being able to "rely" on newer Java component versions.