Fix decoding invalid color combinations #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation for buffer size used a different path than the color used during actual decoding, especially when the flags would expand colors. This would only panic during the decoding of interlaced images. For standard images the remaining data would simply get dropped.
|
That apparently fixed it but I'm having a hard time figuring out exactly which combination of inputs would differ, and which one is intended or correct.. |
fintelia
reviewed
Jun 16, 2020
|
Actually, the color combination in the failing image (RGBA/2-bit) is not allowed per specification. This makes the whole fix appear under a different light, even our encoder rejects it since a recent commit ;) |
This is no longer really necessary since color types would be treated somewhat correctly. However, let's restrict ourselves to the standardized color types for now.
HeroicKatora
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation for buffer size used a different path than the color
used during actual decoding, especially when the flags would expand
colors. This would only panic during the decoding of interlaced images.
For standard images the remaining data would simply get dropped.
Closes: #222