Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @orama/plugin-docusaurus-v3 to support links with anchor #117

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

tpoisseau
Copy link
Contributor

NB. the plugin is available in v3, maybe we should create another issue to update dependencies. I keep v2 to focus only on fixing the issue in this PR.

Closes: #110

NB. the plugin is available in v3, maybe we should create another issue to update dependencies. I keep v2 to focus only on fixing the issue in this PR.

Closes: #110
@tpoisseau tpoisseau linked an issue Jan 27, 2025 that may be closed by this pull request
@tpoisseau tpoisseau requested a review from stropitek January 27, 2025 15:29
Copy link

cloudflare-workers-and-pages bot commented Jan 27, 2025

Deploying image-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7a75c9
Status: ✅  Deploy successful!
Preview URL: https://5be6b5e8.image-js-docs.pages.dev
Branch Preview URL: https://110-orama-does-not-go-to-the-leen.image-js-docs.pages.dev

View logs

@tpoisseau
Copy link
Contributor Author

NB2: @orama//plugin-docusaurus-v3 v2 depends on @orama/plugin-parsedoc@2.1.1 but only 2.1.0 is available on npm, so I used overrides feature of npm

Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you can create an issue for orama v3 and you can take it as well.

upload-coverage input of the nodejs workflow should be set to false.

Otherwise SGTM.

@tpoisseau tpoisseau merged commit b386353 into main Jan 27, 2025
7 checks passed
@tpoisseau tpoisseau deleted the 110-orama-does-not-go-to-the-section-of-the-page-2 branch January 27, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orama does not go to the section of the page where the result is
2 participants