Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rate limit #327

Merged
merged 2 commits into from
Oct 6, 2020
Merged

ci: rate limit #327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c3fc30
ci/test: set 'max-parallel: 3'
umarcor Oct 6, 2020
e849d43
ci/test: add GH_TOKEN to get-toolchain step
umarcor Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
test:
strategy:
fail-fast: false
max-parallel: 2
max-parallel: 3
matrix:
os: [ ubuntu, windows, macos ]
runs-on: ${{ matrix.os }}-latest
Expand Down Expand Up @@ -47,5 +47,7 @@ jobs:
ln -s $(which python) /usr/bin/python3

- run: python ./get-toolchain.py
env:
GH_TOKEN: ${{ github.token }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be marked as a "secure" environment variable or something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It is secure, by itself. That is, the content of github.token depends on the context. If it is executed after someone with write privileges pushed a commit, it has some permissions. If it is executed in a fork, it has the permissions of the forker. If it is executed in a PR, it has read permissions but not write permissions.

This is not a Personal Access Token, which you would need to add to the "Secrets" in the settings of the repo, but it is a secret.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow#permissions-for-the-github_token


- run: ./.github/tests.sh