-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display current_gfxclk if available #250
feat: display current_gfxclk if available #250
Conversation
This seems similar to the previous change with the average/current power input readings. However, reading the drm repo thread, I don't think I entirely understand the behaviour: it looks like after the readings were changed to report the average clockspeed, the values became unstable, but shouldn't it be the other way around? It would make sense for the current reading to jump around, while the average should remain more or less the same. They also suggest to use Similar question regarding your screenshot: the current reading reports 800mhz, while the average is only 21mhz, that seems a bit weird. I would guess that the "current" value is the target clockspeed of the current power state, with the average being the actual (even if average) clockspeed. Please tell me if i am misunderstanding how it works |
There is less documentation for |
I think displaying the current target GFX clock can be helpful in in the OC setup. |
@@ -40,6 +40,11 @@ template $GpuStatsSection: $PageSection { | |||
value: bind template.core-clock; | |||
} | |||
|
|||
$InfoRow { | |||
name: "GPU Core Clock (Current):"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to name the values:
"GPU Core Clock" -> "GPU Core Clock (Average)"
"GPU Core Clock (Current)" -> "GPU Core Clock (Target)"
This way it's more clear on what the values mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but the Average Clock and the Current Clock are clearly separated from Navi10.
I think those values will be the same for pre-Navi10 APU/GPUs. (e.g. Renoir)
Some AMD APUs/GPUs has the Average Clock and the Current Clock, the AMDGPU driver reports the Average Clock in
AMDGPU_INFO_SENSOR_GFX_SCLK
and hwmon.This PR gets the Current clock from
gpu_metrics
and displays it.ref: https://gitlab.freedesktop.org/drm/amd/-/issues/2747