Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using $app instead of $this->app for custom drivers #2

Merged
merged 1 commit into from
Nov 14, 2012

Conversation

jasonlewis
Copy link
Contributor

When firing the closure for a custom driver a $app variable is being passed to the closure, however this variable is not within the scope. It should by using $this->app which is defined in a managers constructor.

…n the constructor.

Signed-off-by: Jason Lewis <jason.lewis1991@gmail.com>
@jasonlewis
Copy link
Contributor Author

@taylorotwell Don't forget about this mate! =)

taylorotwell added a commit that referenced this pull request Nov 14, 2012
Using $app instead of $this->app for custom drivers
@taylorotwell taylorotwell merged commit 9d404af into illuminate:master Nov 14, 2012
@taylorotwell
Copy link
Member

Thanks!

@rumours86 rumours86 mentioned this pull request Mar 1, 2019
walkor added a commit to walkor/support that referenced this pull request Sep 12, 2024
… found

Error: Class "Illuminate\Support\ReflectionClosure" not found in vendor\illuminate\support\Onceable.php:66
Stack trace:
#0 vendor\illuminate\support\Onceable.php(34): Illuminate\Support\Onceable::hashFromTrace()
illuminate#1 vendor\illuminate\database\Eloquent\Concerns\PreventsCircularRecursion.php(29): Illuminate\Support\Onceable::tryFromTrace()
illuminate#2 vendor\illuminate\database\Eloquent\Model.php(1663): Illuminate\Database\Eloquent\Model->withoutRecursion()
#3 admin\app\controller\AccountController.php(85): Illuminate\Database\Eloquent\Model->toArray()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants