Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case when empty suffix "" given to processor #50

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix edge case when empty suffix "" given to processor #50

merged 2 commits into from
Sep 11, 2024

Conversation

tonywu71
Copy link
Collaborator

Description

>>> suffix = ""
>>> suffix = suffix or "<pad>" * 10
>>> suffix
'<pad><pad><pad><pad><pad><pad><pad><pad><pad><pad>'

while we want to allow the user to choose not to use a suffix in ColPaliProcessor.process_queries.

@tonywu71 tonywu71 self-assigned this Sep 10, 2024
ManuelFay
ManuelFay approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@ManuelFay ManuelFay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonywu71 tonywu71 merged commit 34cc713 into main Sep 11, 2024
5 checks passed
@tonywu71 tonywu71 deleted the fix-edge-case-when-no-suffix-in-processor branch September 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuelFay ManuelFay ManuelFay approved these changes

Assignees

@tonywu71 tonywu71

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonywu71 @ManuelFay