Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure colpali-engine package #28

Merged
merged 26 commits into from
Sep 4, 2024
Merged

Restructure colpali-engine package #28

merged 26 commits into from
Sep 4, 2024

Conversation

tonywu71
Copy link
Collaborator

@tonywu71 tonywu71 commented Aug 29, 2024 •
edited
Loading

Added

  • feat: Deprecate interpretability and eval_manager modules
  • feat: Deprecate unused util modules
  • build: Add demo-related deps in colpali-engine[demo]
  • feat: Revamp module organization
  • feat: Restructure the utils module
  • feat: Move ColModelTraining module
  • feat: Lint code + tweaks

Changed

  • doc: Lint Changelog
  • doc: Tweak README

@tonywu71 tonywu71 requested a review from ManuelFay August 29, 2024 11:56
@tonywu71 tonywu71 self-assigned this Aug 29, 2024
@tonywu71 tonywu71 force-pushed the restructure-package branch from fa99ac7 to 9c213f9 Compare August 29, 2024 12:35
@reneleonhardt
Copy link

Amazing work, thank you! Is it still possible to rebase your code?
It would be good to review and merge these improvements as soon as possible. @ManuelFay can you help?

@ManuelFay
Copy link
Collaborator

Yeah that's the plan, but since it's rather a large refacto, we wanna make sure nothing is breaking ! Any reason you need this now ? No new features are introduced wrt current code on main branch, it's essentially cleaning up stuff ?

@tonywu71 tonywu71 force-pushed the restructure-package branch from c385c58 to b9b5304 Compare September 3, 2024 13:38
tonywu71
tonywu71 commented Sep 3, 2024
View reviewed changes
Copy link
Collaborator Author

@tonywu71 tonywu71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just a few suggestions you can check + linting before merging!

colpali_engine/models/bi_encoders/bipali_architecture.py Show resolved Hide resolved
colpali_engine/utils/processing_utils/colidefics_processing_utils.py Outdated Show resolved Hide resolved
colpali_engine/utils/processing_utils/colpali_processing_utils.py Outdated Show resolved Hide resolved
demo/app.py Outdated Show resolved Hide resolved
ManuelFay
ManuelFay approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@ManuelFay ManuelFay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked and change a few things (which you saw).
Training runs well now so LGTM

@ManuelFay ManuelFay merged commit 08693ae into main Sep 4, 2024
@ManuelFay ManuelFay deleted the restructure-package branch September 4, 2024 15:15
This was referenced Sep 7, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuelFay ManuelFay ManuelFay approved these changes

Assignees

@tonywu71 tonywu71

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonywu71 @reneleonhardt @ManuelFay