Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteKit migration #349

Open
wants to merge 60 commits into
base: main
Choose a base branch
from
Open

SvelteKit migration #349

wants to merge 60 commits into from

Commits on Jul 5, 2022

  1. Perform initial transformation to SvelteKit

    This is a mega-commit since everything is tied together (it is a framework migration after all),
    but it mostly consists of renames and minor adjustments.
    This includes the following:
    - Move files to the appropriate locations for SvelteKit
    - Change any "attractions" imports in docs to use "$lib"
    - Define aliases in CSS without a custom importer (for client usage)
    - Move SCSS of component docs (`.svx` files) into the component itself (path aliases didn't work here)
    - Remove clipboard-polyfill
    aabounegm committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    918cdad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2bb4478 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c201cca View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    de5777a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c7ebde4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f1d6789 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    33bb1d3 View commit details
    Browse the repository at this point in the history
  8. Fix possible undefined property access

    When segment is an empty string
    aabounegm committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    740c1de View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ecac770 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ac4c2eb View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    60c9b81 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    89b1a09 View commit details
    Browse the repository at this point in the history
  13. Replace JSDoc w/ type annotation in required props

    Using the RegEx `\* @type \{([\S\r]*)\}\s+(\*\/\s+export let \w+);`
    with replacement `$2: $1;`
    aabounegm committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    a85cf1e View commit details
    Browse the repository at this point in the history
  14. Replace all _class JSDoc annotation with TS type

    Using the RegEx `\* @type \{(.*)\}\n.*(\s+export let \w+Class)`
    with replacement `*/$2: $1`
    aabounegm committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    e81193b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5383f0d View commit details
    Browse the repository at this point in the history
  16. Replace JSDoc with TS types for optional props

    that cannot be trivially inferred
    Using RegEx `\* @type \{(.+)\}\s+\*\/(\n\s*export let \w+) =`
    replaced with `*/$2: $1 =`
    aabounegm committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    f54c434 View commit details
    Browse the repository at this point in the history
  17. Replace more JSDoc annotations with proper TS

    Mainly in local variables and function parameters
    and remove empty JSDoc comments
    aabounegm committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    3a0fb8f View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    fcbffa4 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    ef0e7d3 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    0a59495 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    534605d View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Configuration menu
    Copy the full SHA
    2c7dae7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f181c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c0f7aa3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5fd8936 View commit details
    Browse the repository at this point in the history
  5. Remove PNPM workspaces

    aabounegm committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    f330786 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2a6c9f0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    149b901 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8b15d7a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e30b85c View commit details
    Browse the repository at this point in the history
  10. Automatically replace links with absolute URLs

    Using the RegEx `(?<=<script lang="ts">)((.|\r|\n)+)\(\.\/docs`
    replaced with `\n  import { base } from '$app/paths';$1({base}/docs`
    inside the `routes` directory.
    
    Followed by a simple replacement of `\(\.\/docs` with `({base}/docs`
    to handle multiple occurences in one file
    aabounegm committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    2f62f92 View commit details
    Browse the repository at this point in the history
  11. Fix breadcrumbs href and segment

    Workaround type issue
    aabounegm committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    9c1b03d View commit details
    Browse the repository at this point in the history
  12. Install lint-staged again

    aabounegm committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    431cb8e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    af914b3 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    168c1f1 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6db2d0b View commit details
    Browse the repository at this point in the history
  16. Setup pnpm before Node.js

    For the default caching mechanism to work, probably
    aabounegm committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    9b959f4 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    46adf32 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Configuration menu
    Copy the full SHA
    ea541b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e2be504 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c9a57c View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Configuration menu
    Copy the full SHA
    3717dab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f64ba34 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b7e879 View commit details
    Browse the repository at this point in the history
  4. Fix type errors here and there

    Mostly just type-casting, ensuring compatibility, and
    making use of flow analysis with type guards
    aabounegm committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    4ca4d64 View commit details
    Browse the repository at this point in the history
  5. Fix minor ESLint problems

    aabounegm committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    738703a View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. update Sapper references

    benmccann committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    097eab4 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Merge pull request #350 from benmccann/sapper-references

    update Sapper references
    aabounegm authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    50bacb2 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2022

  1. Remove $lib alias from SCSS

    aabounegm committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    0c93a29 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    560a3df View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c66a69 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a3f2018 View commit details
    Browse the repository at this point in the history
  5. Replace complex types with ComponentType helper

    And `ComponentProps` as well
    aabounegm committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    ce1593e View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Update dependencies (minor)

    aabounegm committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    11380ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef1d8ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32f9571 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Update dependencies

    aabounegm committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    af3013f View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Configuration menu
    Copy the full SHA
    4367a14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e6ed3de View commit details
    Browse the repository at this point in the history
  3. Update to SvelteKit 1.0

    aabounegm committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    5da9987 View commit details
    Browse the repository at this point in the history