Updated email functionality #3
Open
+67
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shreyas208
commented
Oct 20, 2018
shreyas208
commented
- Updated email.js to use config in config.js
- Updated sample config with SMTP config info
wadefagen
reviewed
Oct 20, 2018
There was a problem hiding this comment.
Given this is an @illinois project and the only known use-cases are all in CS on UIUC-networked machines, I'd strongly prefer to see the illinois-config land in this repo as well (from slack).
The usual future-case will be for a future TA/CA to download this, deploy it, and also wonder why no e-mails are being sent. Having it just work by default seems best (we can have different configs only if it's further adopted).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.