Radiation for production #908
Conversation
MTCam
added
Production Feeder
…grad doesn't do anything
not necessary since we aren't checking accuracy
| if interface_radiation: | ||
| def make_fluid_boundary(interface_tpair): | ||
| if interface_noslip: | ||
| fluid_bc_class = IsothermalWallBoundary | ||
| else: | ||
| fluid_bc_class = IsothermalSlipWallBoundary | ||
| return fluid_bc_class(interface_tpair.ext.temperature) | ||
|
|
||
| def make_fluid_boundary(interface_tpair): | ||
| return fluid_bc_class( | ||
| interface_tpair.ext.kappa, | ||
| interface_tpair.ext.temperature) | ||
| def make_wall_boundary(interface_tpair): | ||
| return InterfaceWallRadiationBoundary( | ||
| interface_tpair.ext.kappa) | ||
|
|
||
| def make_wall_boundary(interface_tpair): | ||
| return InterfaceWallBoundary( | ||
| interface_tpair.ext.kappa, | ||
| interface_tpair.ext.temperature) | ||
| else: | ||
| def make_fluid_boundary(interface_tpair): | ||
| if interface_noslip: | ||
| fluid_bc_class = InterfaceFluidNoslipBoundary | ||
| else: | ||
| fluid_bc_class = InterfaceFluidSlipBoundary | ||
| return fluid_bc_class( | ||
| interface_tpair.ext.kappa, | ||
| interface_tpair.ext.temperature) | ||
|
|
||
| def make_wall_boundary(interface_tpair): | ||
| return InterfaceWallBoundary( | ||
| interface_tpair.ext.kappa, | ||
| interface_tpair.ext.temperature) |
There was a problem hiding this comment.
As far as I can tell, this block is instantiating new class objects these every time it is called. This is a mild performance concern for me. Could we not set thefluid_bc_class upon creation, and update its data on the fly instead of re-instantiating with every call?
There was a problem hiding this comment.
AFAIK the classes only exist during compilation, so I don't think this would affect performance.
Thanks! (FYI, the "real" radiation PR is #893. This one is that + ESDG. Strictly speaking I guess that means ESDG should merge before radiation? But I think if we merge #893 into main, then merge this into #922, and finally merge that up with the new main, it should work out in the end.) |
No merge, only production feeder
Questions for the review: