Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use miniforge in CI #1071

Merged
merged 1 commit into from
Oct 2, 2024
Merged

use miniforge in CI #1071

merged 1 commit into from
Oct 2, 2024

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Oct 1, 2024

cc illinois-ceesd/emirge#174

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener self-assigned this Oct 1, 2024
@matthiasdiener matthiasdiener enabled auto-merge (squash) October 1, 2024 18:51
@matthiasdiener matthiasdiener merged commit 77ee510 into main Oct 2, 2024
12 of 13 checks passed
@matthiasdiener matthiasdiener deleted the miniforge branch October 2, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants