Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link doesn't work for vuetify 2 #29

Closed
noobling opened this issue Jul 25, 2019 · 9 comments
Closed

Add link doesn't work for vuetify 2 #29

noobling opened this issue Jul 25, 2019 · 9 comments
Labels
bug Something isn't working vuetify 2

Comments

@noobling
Copy link

Thanks for your work man.

I am not sure if this is a vuetify 2 specific issue but I can't add a link when I click the button it just closes.

Hopefully, this helps.

image

And my package.json

  "dependencies": {
    "@nuxtjs/axios": "^5.5.4",
    "@nuxtjs/pwa": "^2.6.0",
    "@nuxtjs/vuetify": "^1.0.0",
    "filestack-js": "^3.3.5",
    "filestack-vue": "^2.0.0",
    "lodash.get": "^4.4.2",
    "nuxt": "^2.0.0",
    "tiptap-vuetify": "^1.5.0"
  },
@iliyaZelenko
Copy link
Owner

Hi, glad you are using my package, thanks.

I have not tested this for the Vuetify 2. It's good that at least something works.

Like this issue if you are using the Vuetify 2 and you want me to quickly make support for the Vuetify 2.

I plan to add support for Vuetify 2, but I don’t know what to do with version 1, maybe I’ll stop supporting it.

@iliyaZelenko iliyaZelenko added bug Something isn't working vuetify 2 labels Jul 25, 2019
@fabioebner
Copy link

@noobling how u configure to work with vuetify 2? can U show? tks

@aspben
Copy link

aspben commented Aug 1, 2019

Maybe vuetify 2 should be a separate issue but the tiptap portion work's fine only the vuetify component arn't working
image

Look like the same issue described in the docs ( a-la-carte / vuetify loader). It look like there is a different way to do it in vuetify v2 but I can't figure out what. I tried importing component manually in main.js and in the component that call tiptap-vuetify but no luck.

Thank btw for the pacakge !

@noobling
Copy link
Author

noobling commented Aug 1, 2019

import Vue from "vue";
import Vuetify, { VTooltip, VToolbar, VCard, VIcon, VBtn } from "vuetify/lib";
import { TiptapVuetifyPlugin } from "tiptap-vuetify";
import "tiptap-vuetify/dist/main.css";
Vue.use(Vuetify, {
  components: {
    VTooltip,
    VToolbar,
    VCard,
    VIcon,
    VBtn
  }
});
Vue.use(TiptapVuetifyPlugin, { iconsGroup: "mdi" });
export default new Vuetify({
  icons: {
    iconfont: "mdi"
  }
});

Here is a way to fix it. This is the vuetify.js plugin file.

I think the root cause is due to Vuetify Loader not detecting the compiled dist file and adding the auto imports. I think before Vuetify Vue.use(vuetify) would inject all the vuetify components now by default it doesn't as you can see here https://github.com/vuetifyjs/vuetify/blob/master/packages/vuetify/src/install.ts#L22
That's why we do the above to manually register the required components so we can use them without explicitly importing them.

@aspben
Copy link

aspben commented Aug 1, 2019

it work nicely. thank a lot

@wobsoriano
Copy link

@noobling Good fix thanks. Do you know how to remove the warning > tiptap-vuetify: The current language "en" is not yet available. Using language "en" by default.? Thanks.

@iliyaZelenko
Copy link
Owner

@sorxrob you can try something like this: Vue.prototype.$vuetify = { lang: 'en' } before using the Vue.use(TiptapVuetifyPlugin)
But this is not an ideal solution. I thought this warning would not bother people.

iliyaZelenko pushed a commit that referenced this issue Oct 6, 2019
# [2.0.0](v1.7.0...v2.0.0) (2019-10-06)

### Features

* architecture changes ([14b6604](14b6604))
* rewrite plugin, dependency update, small refactor ([f0a5d06](f0a5d06))
* **eslint:** rollback versions for ESLint's tools until they solve the problems with the Vue ([e0a29ef](e0a29ef))
* **extensions, i18n, icons:** rewrite extensions for a new look, news i18n for links, fix icons ([42cdc13](42cdc13))
* **vuetify 2:** rewrote the components for the Vuetify 2. Also other minor changes ([7ac50f3](7ac50f3)), closes [#33](#33) [#29](#29) [#43](#43) [#21](#21) [#18](#18)

### BREAKING CHANGES

* Vuetify version, accces to vuetify via required property in options
* extensions are now used differently
@iliyaZelenko
Copy link
Owner

I released version 2 with support for Vuetify 2, everything should work now.

@noobling
Copy link
Author

noobling commented Oct 7, 2019

Thanks for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vuetify 2
Projects
None yet
Development

No branches or pull requests

5 participants