Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image support? #16

Closed
assoft opened this issue Jun 7, 2019 · 18 comments
Closed

Image support? #16

assoft opened this issue Jun 7, 2019 · 18 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@assoft
Copy link
Contributor

assoft commented Jun 7, 2019

Are you considering supporting the image/embeds extension? When can you think about it?
@iliyaZelenko iliyaZelenko added the question Further information is requested label Jun 7, 2019
@iliyaZelenko
Copy link
Owner

Hey, @assoft.

First of all, thanks for giving me a star, this is what motivates me to work with the project.

If you need it, then I will start working on it today, I think it will take a few days at most, I hope it will not be long for you?

I want this project to become popular, so I need to satisfy the desires of users.

@iliyaZelenko
Copy link
Owner

iliyaZelenko commented Jun 7, 2019 •
edited
Loading

Do you have any ideas about uploading images? It is very interesting to me.

@assoft
Copy link
Contributor Author

assoft commented Jun 7, 2019

Hi @iliyaZelenko,

First of all, I want to thank you for starting this project.

I think you've completed a serious shortcoming to Vuetify.

API is perhaps the best way to upload images

No, absolutely no rush for me

I wish you good work.

i'm sorry i'm not good enough to speak english.

@assoft
Copy link
Contributor Author

assoft commented Jun 7, 2019

Example On Nuxt.js

Thank you @iliyaZelenko

@Flambe
Copy link
Contributor

Flambe commented Jun 17, 2019

I'd definitely be interested in this too!

What ideas were you looking for @iliyaZelenko ?

@iliyaZelenko
Copy link
Owner

Thanks for the support guys. I work on it and I have a lot of plans. I will try to release the update as soon as I can.

This has been a little delayed since I am working in the company now and I am changing the project structure cardinally so that it is easier for further development and flexible for user expansion. You will have the functionality to easily add your own buttons (not necessarily buttons) and change existing ones.

I plan to add the extension for loading images into a separate package in order to make the editor modular. I will create the same separate package for the extension with which you can add emoticons.

Maybe I will also have to create a separate package for each package so that these extensions can be used in tiptap without the need for vuetify.

For the images extension, I plan to make a system of plugins, with the help of which you can choose hosting for downloading or your own REST API.

What ideas were you looking for @iliyaZelenko ?

These can be any of your ideas. For example, how do I make this as flexible as possible for users.

I also added the ability to choose where to display the buttons: in the toolbar or in the tooltip.

@Flambe
Copy link
Contributor

Flambe commented Jun 17, 2019

No rush from me either.

The separate packages sounds like a really good idea, then we can just pull in what we need.

I'm not sure what the best practice for this is, but maybe let the user pass an async callback which lets them do the API query themselves?

Really liking your plans for the future!

@sangemi
Copy link

sangemi commented Jul 2, 2019

Hi, I also wait image support!
Please consider about AWS S3 upload :-) and Drag and drop

@iliyaZelenko iliyaZelenko added the enhancement New feature or request label Oct 5, 2019
@iliyaZelenko iliyaZelenko mentioned this issue Oct 13, 2019
Closed
@iliyaZelenko iliyaZelenko mentioned this issue Oct 23, 2019
Open
@websitevirtuoso
Copy link

IT would be good, hope we will get it soon

iliyaZelenko added a commit that referenced this issue Nov 3, 2019
@iliyaZelenko
feat(images): image extensions
e464b2b 
support for adding images (Image extension from tiptap)

re #16
iliyaZelenko pushed a commit that referenced this issue Nov 3, 2019
@semantic-release-bot
chore(release): 2.6.0 [skip ci]
ebf314d 
# [2.6.0](v2.5.0...v2.6.0) (2019-11-03)

### Bug Fixes

* **props:** fix warning Invalid default value for prop "cardProps" ([f15d554](f15d554)), closes [#89](#89)

### Features

* **images:** image extensions ([e464b2b](e464b2b)), closes [#16](#16)
@iliyaZelenko
Copy link
Owner

iliyaZelenko commented Nov 3, 2019 •
edited
Loading

Added in 2.6.0.

image

Use Image extension for this. Example here.

Note: since the original extension works through base64, then I had to do it too. That is, the pictures are not uploaded to the server, but stored in the editor’s content. In the future I plan to make a real upload, I will have to create my own image extension for tiptap. Also I will try to fix resize issue in my extension.

@nibytes
Copy link

nibytes commented Nov 12, 2019 •
edited
Loading

I will try to fix resize issue in my extension.

Hello Ilia, did you manage to fix it?

@iliyaZelenko
Copy link
Owner

@nibytes not yet. I will let you know when will be ready.

@rajesh-h
Copy link

@iliyaZelenko Do you think you will be completing this image upload soon? It's a much awaited feature.

@iliyaZelenko iliyaZelenko mentioned this issue Feb 28, 2020
Closed
@catthecreator
Copy link

Hi! I also do not have enough load images.
You did a great job! Thank you very much!

@avgeeklucky avgeeklucky mentioned this issue May 2, 2020
Merged
2 tasks
iliyaZelenko pushed a commit that referenced this issue May 8, 2020
@avgeeklucky
feat: Custom images upload
3af6fc3 
re #141 #16
iliyaZelenko pushed a commit that referenced this issue May 8, 2020
@semantic-release-bot
chore(release): 2.16.0 [skip ci]
4736738 
# [2.16.0](v2.15.0...v2.16.0) (2020-05-08)

### Features

* Custom images upload ([3af6fc3](3af6fc3)), closes [#141](#141) [#16](#16)
@ksdhir
Copy link

ksdhir commented May 16, 2020

Does Image Uploader support file types like .jpeg or .png ?
Also it would be great to add Image size limit feature i.e 5 mb max file size. Does the extension currently support this?

@iliyaZelenko
Copy link
Owner

@ksdhir the default uploadof pictures works through bass64 (.jpeg and .png must be supported), this can be seen by src of image. This editor gives you the flexibility to upload pictures to your backend server. You must write the download code yourself. In the end, you will need to transfer the link to the downloaded image for this editor to use it. More info here.

@nuolmakara16
Copy link

@avgeeklucky Sorry! I am using custom image upload components in my nuxt project, everything seem to work fine until I try to use it with store using this.$store. I wonder are there anyway I could access store in the custom component? I'm really appreciate your answer!

@abdulrahmank
Copy link

abdulrahmank commented Sep 16, 2023 •
edited
Loading

This is a great feature indeed!

Just curious was there any fix for resizing?
@iliyaZelenko thank you for such a great project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests