Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Mass density" is the more rigorous and technically correct version (though I believe the SI brochure does essentially say they're equivalent), so I think we should at least expose this as an option.
To retain backwards compatibility, this PR contains
pub type Density<U, V> = MassDensity<U, V>
. I'd rather not have this from an idealistic standpoint, but from a practical perspective, it makes sense to not break backwards compatibility for this (which I would expect to be one of the more commonly-used quantities). We could also just make the type alias work the other way around (pub type MassDensity<U, V> = Density<U, V>
) and thereby obtain a single-line diff (two lines with docs), but I do think that this is the more semantically correct version.