Add liter-based volume units to si #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial review looks good. Will go over the details tomorrow. |
iliekturtles
requested changes
Mar 22, 2019
| @gigaliter: prefix!(milli) * prefix!(giga); "GL", "gigaliter", "gigaliters"; | ||
| @megaliter: prefix!(milli) * prefix!(mega); "ML", "megaliter", "megaliters"; | ||
| @kiloliter: prefix!(milli) * prefix!(kilo); "kL", "kiloliter", "kiloliters"; | ||
| @hectoliter: prefix!(milli) * prefix!(hecto); "hL", "hectoliter", "hectoliters"; |
There was a problem hiding this comment.
deca prefix got missed. Add for tests as well.
| test::<v::femtoliter, v::liter>(prefix!(femto)); | ||
| test::<v::attoliter, v::liter>(prefix!(atto)); | ||
| test::<v::zeptoliter, v::liter>(prefix!(zepto)); | ||
| test::<v::yoctoliter, v::liter>(prefix!(yocto)); |
There was a problem hiding this comment.
Add a blank line just above the function.
|
I see the force push but not the changes. Try again? |
|
Odd, seems I forgot to stage. I’ll fix that in a bit here. |
iliekturtles
approved these changes
Mar 24, 2019
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds liter-based (i.e.
literand all prefixes) units tosi::volume. The included tests testliteragainstcubic_meterand then all of the prefixedlitervariants againstliterto ensure that they are all correct.