Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor directory structure and update script paths #118

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

reactmore
Copy link
Contributor

@reactmore reactmore commented Jul 23, 2024

Pull Request

Refactor directory structure and update script paths

Deskripsi

Di kode sebelumnya di root ada index.php dan public ada index.php mungkin karena awalnya pake xampp cuman kalo pake server live kan root bisa di letakan di luar public_html jadi aku balikin ke struktur CI awal dan edit httacess biar bisa akses langsung ke public tanpa harus nulis public di browser dan template dan yang pake selain xampp seperti laragon gk dapet masalah path

Masalah Terkait

Jika ada isu terkait, silakan cantumkan issue di sini.

Perubahan yang Diajukan

  • delete index.php on root folder
  • Edit .htaccess rules in root folder
  • Changed paths from public/assets to assets to reflect new directory structure
    • Changed <script src="public/assets/js/core/jquery-3.5.1.min.js"></script>
    • To <script src="assets/js/core/jquery-3.5.1.min.js"></script>

Checklist

Pastikan semua item berikut telah Anda periksa sebelum mengirimkan permintaan pull:

  • Perubahan telah diuji dan berfungsi dengan baik.
  • Dokumentasi telah diperbarui sesuai dengan perubahan.
  • Tidak ada konflik merge dengan cabang utama.

Catatan Tambahan

Tambahkan catatan tambahan atau informasi penting lainnya di sini.

* delete index.php on root folder

* Edit  .htaccess rules in root folder

* Revert code Block Access

* Update script paths in views templates

- Updated script paths in template files within the views folder
- Changed paths from public/assets to assets to reflect new directory structure
@reactmore reactmore changed the title Refactor directory structure and update script paths (#1) Refactor directory structure and update script paths Jul 23, 2024
@ikhsan3adi ikhsan3adi self-requested a review July 24, 2024 03:51
@ikhsan3adi ikhsan3adi added the enhancement New feature or request label Jul 24, 2024
Fix root index.php not found on php spark serve
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert #63 spark

@ikhsan3adi ikhsan3adi merged commit dc6cf82 into ikhsan3adi:master Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants