Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

Split httpd configuration #9

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Split httpd configuration #9

merged 3 commits into from
Sep 21, 2017

Conversation

ikedas
Copy link
Owner

@ikedas ikedas commented Sep 16, 2017

I feel it would be better to split httpd copnfiguration by el6 & el7.

@ikedas ikedas changed the title Split httpd copnfiguration Split httpd configuration Sep 16, 2017
@xavierba
Copy link
Collaborator

Splitting the configuration would imply fixing stuff at 2 places when the needs arise. Not a big deal, but still worth a note. I do have a patch to fix the fcgid directives that would need to be applied twice.
xavierba@4df41e0

Also, rather than naming the files el6 and el7, I'd rather name them httpd-22 and httpd-24. Although I do understand the focus on EL, we should try to be agnostic of the distro.
On a related topic, I do have a patch to rename README.RPM.md from el6/el7 to sysvinit/systemd.
xavierba@0787883

@ikedas
Copy link
Owner Author

ikedas commented Sep 20, 2017

@xavierba, thanks for suggestions.

Splitting the configuration would imply fixing stuff at 2 places when the needs arise. Not a big deal, but still worth a note. I do have a patch to fix the fcgid directives that would need to be applied twice.
xavierba@4df41e0

I suppose it's clearer for admins to remove conditional settings not related to their platforms.

mod_fastcgi has gone and moving to mod_fcgid equivalents is good idea. However, they may not be put in sympa.conf. I think they would be better to be replaced with comment lines to recommend editing fcgid.conf.

Also, rather than naming the files el6 and el7, I'd rather name them httpd-22 and httpd-24. Although I do understand the focus on EL, we should try to be agnostic of the distro.
On a related topic, I do have a patch to rename README.RPM.md from el6/el7 to sysvinit/systemd.
xavierba@0787883

It makes sense. I'll rename them to sympa-httpd-22-fcgid.conf and so.

@ikedas ikedas merged commit 78986b3 into master Sep 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants