[IKASAN-2062] Try and make SftpToJmsFlowTest pass every time #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -397,9 +397,11 @@ public void fireScheduledConsumer() | |||
| { | |||
| JobDetail jobDetail = ((ScheduledComponent<JobDetail>)consumer).getJobDetail(); | |||
| Trigger trigger = newTrigger().withIdentity("name", "group").forJob(jobDetail).build(); | |||
| // adding a sleep in test to give quartz a chance to see a new scheduled time in consumer.scheduleAsEagerTrigger | |||
There was a problem hiding this comment.
This doesnt seem like a solution - adding sleeps are the causes of much of our intermittent failures. Would prefer we tracked the real root of the problem down
mick-stewart73
approved these changes
Feb 20, 2022
mick-stewart73
deleted the
Bug/IKASAN-2062-Fix-SftpToJmsFlowTest-3.2.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.