Null terminate PyBytesObject.ob_sval

ijl · Jun 3, 2022 · d4146d1 · d4146d1
1 parent 651b700
commit d4146d1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/serialize/writer.rs b/src/serialize/writer.rs
@@ -27,6 +27,9 @@ impl BytesWriter {
 
     pub fn finish(&mut self) -> NonNull<PyObject> {
         unsafe {
+            unsafe {
+                std::ptr::write(self.buffer_ptr(), 0);
+            };
             (*self.bytes.cast::<PyVarObject>()).ob_size = self.len as Py_ssize_t;
             self.resize(self.len as isize);
             NonNull::new_unchecked(self.bytes as *mut PyObject)

diff --git a/test/test_api.py b/test/test_api.py
@@ -200,3 +200,10 @@ def test_bytes_buffer(self):
         self.assertEqual(
             orjson.dumps([a, b, c]), f'["{a}","{b}","{c}"]'.encode("utf-8")
         )
+
+    def test_bytes_null_terminated(self):
+        """
+        dumps() PyBytesObject buffer is null-terminated
+        """
+        # would raise ValueError: invalid literal for int() with base 10: b'1596728892'
+        int(orjson.dumps(1596728892))