Fix crash in mpv_set_property during termination, #3596 #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit in the pull request will: - Rename the PlayerCore property isMpvTerminated to isMpvTerminating to reflect that termination has been initiated and being processed asynchronously - Change existing references to isMpvTerminated to use new name - Change PlayerCore.terminateMPV to set isMpvTerminating to true right before starting the termination process - Change PlayerCore.syncUI to do nothing if mpv is terminating - Change MPVController.mpvQuit to remove observers MPVController registered before sending the quit command to mpv - Change many MPVController methods to check to see if mpv is being terminated
This was referenced Dec 30, 2021
|
Hold of reviewing this PR. I have plans to change how termination is handled that may eliminate the need for this PR. |
|
Closing. A more extensive fix in PR #3961 addresses the problem in a different way by closing windows before shutting down mpv. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit in the pull request will:
Rename the PlayerCore property isMpvTerminated to isMpvTerminating to
reflect that termination has been initiated and being processed
asynchronously
Change existing references to isMpvTerminated to use new name
Change PlayerCore.terminateMPV to set isMpvTerminating to true right
before starting the termination process
Change PlayerCore.syncUI to do nothing if mpv is terminating
Change MPVController.mpvQuit to remove observers MPVController
registered before sending the quit command to mpv
Change many MPVController methods to check to see if mpv is being
terminated
This change has been discussed with the author.
It implements / fixes issue Crash in mpv_set_property during termination #3596.
Description: