-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full support for Win32 and many other enhancements #11
base: master
Are you sure you want to change the base?
Conversation
Conflicts: mrbgem.rake
dln_search_exe_r now automatically appends .exe if the program searched for doesn't end in .exe while searching spawn now properly uses the provided module rather than executing everything in a cmd/sh module fixed piping of modules not called via cmd/sh
022992f
to
5cea161
Compare
3a06f78
to
8cb1847
Compare
fixed wrong argument resolving for cases where more than one argument is provided, but dln cant find anything
Full support for Win32 platform is great. Nice work. But this PR has a few issues:
|
@tsahara Thanks for your comments.
Both repos are under MIT license. What exactly do you mean and what needs to me modified?
OK, but how we can go from here? A merge without detailed review doesn't seem possible. On the the other side I want to avoid having a second mruby-process mgem. We've added lots of tests and ci integration to make sure that everything works as expected. In case of questions, suggestions and future support we're open to incorporate. We had to touch all the files so a PR which adds just a file or a method isn't possible. |
@tsahara @mattn @akiray03
As hinted in #1 here comes our PR
The PR adds full support for Win32 platform and various enhancements for posix platform. Honestly its more a rewrite than just a PR.
We would be happy to get some feedback and hope you will merge it. See the README for whats supported.
https://github.com/appPlant/mruby-process/tree/windows