Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert version file's VERSION.BUILD to match current release #385

Merged
merged 1 commit into from
Jan 16, 2021

Conversation

HebaruSan
Copy link
Contributor

4773123 changed VERSION.BUILD in the remote version file, which tells KSP-AVC and CKAN that it is for a different version than the download, which prevents the other changes in that commit from applying and keeps KIS 1.28 stuck as compatible with KSP 1.8.

Recommend changing the BUILD property back so it matches and the intended compatibility can be applied. If you have some kind of automated build script populating this, probably a good idea to remove that as well.

Tagging @ihsoft to ensure GitHub sends a notification.

@ihsoft
Copy link
Owner

ihsoft commented Jan 16, 2021

Wow! Didn't realize it can affect CKAN. Thanks.

@HebaruSan
Copy link
Contributor Author

Thanks for the merge! That should help folks who are getting confused about the compatibility (sometime within the next 30 minutes).

@Sinomen
Copy link

Sinomen commented Jan 16, 2021

Would you mind to change the compatibility information for 1.27 too to KSP 1.11. please?

Thanks in advance :)

@HebaruSan
Copy link
Contributor Author

@Sinomen That kind of maintenance the CKAN team can do ourselves (I know it's confusing; to sum up, the current release has special automatic treatment and the older releases are maintained manually). If you are interested in trying that, you can edit the files here and submit pull requests:

@Sinomen
Copy link

Sinomen commented Jan 16, 2021

Never did a pull request, uh... and I don't want to botch up things. So what would I do then exactly?

@HebaruSan
Copy link
Contributor Author

It's pretty quick once you get used to it:

  1. Click the file name to view it
  2. Click the pencil icon towards the upper right to edit it
  3. Make your changes
  4. At the bottom there is a box for typing a short description
  5. Keep clicking the green buttons until you end up making a pull request

Let's continue this back at KSP-CKAN/NetKAN#8291 so we aren't spamming email notifications over here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants