Reformate demographic_id and refactor disaggregate.py #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up high level splitting api to make the output type an argument rather than use separate functions
Fixed bug with argument order, got rid of split_dataframe_rate
Also updated example notebook for dataframe splitting to match current changes.
Minor fixes to docstrings, typing
zhengp0
reviewed
Mar 6, 2023
| model=model, | ||
| observed_total_se=x['obs_se'] | ||
| if demographic_id_columns is not None: | ||
| splitting_df['demographic_id']=list( |
There was a problem hiding this comment.
Hi @AHsu98, I don't think create 'demgraphic_id' column is necessary, especially you will delete it at the end of the function. Maybe I am missing something. If you can explain a little here that will be great!
Pandas set_index function can take multiple column to create the index, and reset_index will flatten out the hierarchical index.
There was a problem hiding this comment.
Yeah, setting it as demographic id here was kind of a hack, I don't really like it. I set it as a tuple because otherwise I was getting errors around the index name not matching with the population df, I'll make an issue and try to fix it later!
zhengp0
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty significant changes here, we should probably update pypi version after this and bump version.
The version in this branch is what I used to make the example from Lauryn's data.