Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated to use getter and setter #23

Merged
merged 4 commits into from
Mar 1, 2023
Merged

updated to use getter and setter #23

merged 4 commits into from
Mar 1, 2023

Conversation

AHsu98
Copy link
Contributor

@AHsu98 AHsu98 commented Feb 28, 2023

Removed get_set_rate_pattern, and changed it to use @Property, .setter and .getter. Fix for #22

@AHsu98
updated to use getter and setter with
cdbbef2 
Removed get_set_rate_pattern, and changed it to use @Property, .setter and .getter. Fix for #22
@AHsu98 AHsu98 requested a review from zhengp0 February 28, 2023 21:26
@AHsu98 AHsu98 changed the title updated to use getter and setter with updated to use getter and sette Feb 28, 2023
@AHsu98 AHsu98 changed the title updated to use getter and sette updated to use getter and setter Feb 28, 2023
zhengp0
zhengp0 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@zhengp0 zhengp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@AHsu98 AHsu98 merged commit fff193f into main Mar 1, 2023
@zhengp0 zhengp0 deleted the use-getter-setter branch March 6, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengp0 zhengp0 zhengp0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AHsu98 @zhengp0