Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trend Line on Graph Starts from Left Instead of Right #1

Closed
ihasTaco opened this issue Jul 31, 2023 · 3 comments
Closed

Trend Line on Graph Starts from Left Instead of Right #1

ihasTaco opened this issue Jul 31, 2023 · 3 comments
Assignees
Labels
bug Something isn't working testing possible solution Testing a possible solution

Comments

@ihasTaco
Copy link
Owner

In the current implementation of ServerQuery, the trend line on the graph starts from the left side and moves towards the right. This behavior contradicts the expected flow of time, as newer data points should appear on the right side of the graph, causing the line to move from right to left.

This issue might cause confusion among users, as they might interpret the graph as displaying data in reverse chronological order.

We need to adjust the graph generation logic to ensure the trend line starts from the right side of the graph, representing the most recent data, and moves to the left as new data points are added.

Steps to Reproduce:

  • Start the ServerQuery bot and let it generate a graph. (This will take at least a day to fully fill the graph and make the trend line to start filling with data)
  • Observe the direction of the trend line on the graph.

Expected Outcome:
The trend line should start from the right side of the graph and move left as new data points are added, representing the flow of time correctly.

Actual Outcome:
The trend line starts from the left side of the graph and moves to the right, which could lead to misinterpretation of the graph data.

Possible Solution
During development, the 'Player Amount' line exhibited similar behavior. The solution was to pad the 'Players' variable with zeroes until it was completely populated. Applying the same technique to the 'trend_data' should resolve this issue. Importantly, this change will not affect the server_info.json file, as the adjustment is made within the graph script itself and is not written to the JSON file.

@ihasTaco ihasTaco added the bug Something isn't working label Jul 31, 2023
@ihasTaco ihasTaco self-assigned this Jul 31, 2023
@ihasTaco
Copy link
Owner Author

ihasTaco commented Aug 1, 2023

testing a quick fix for this!

@ihasTaco ihasTaco added the testing possible solution Testing a possible solution label Aug 1, 2023
ihasTaco added a commit that referenced this issue Aug 2, 2023
I believe I have fixed a couple of issues:

* Possible Fix for [issue #9](#9)

* Possible Fix for [issue #1](#1)

Added a new feature

* Added a logging system
@ihasTaco
Copy link
Owner Author

ihasTaco commented Aug 2, 2023

I am still testing this but alpha.2 release should fix this issue

I had to make a new server to test this and am currently waiting for it to fill with data, so I will have a confirmation in a day or so!

@ihasTaco ihasTaco linked a pull request Aug 2, 2023 that will close this issue
@ihasTaco
Copy link
Owner Author

ihasTaco commented Aug 4, 2023

This issue has been fixed with the new develop build

@ihasTaco ihasTaco closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing possible solution Testing a possible solution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant