Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configs for more web browsers #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boredsquirrel
Copy link

As there seems to be no obvious way to use the same profile for more apps, I duplicated the configs, changing the paths to binaries and desktop entries.

I also added a few default configs needed to make videocalls work.

I renamed "firefox.toml" to "firefox_legacy.toml" to make it look less like "the normal config" in comparison to the wayland one.

I changed the chromium config to use wayland and not x11.

I added the GNOME portal things to firefox, needed to make them work.

@igo95862
Copy link
Owner

Hello @boredsquirrel

Thank you submitting this PR. Unfortunately I have paused adding any new profile for now as I plan on adding a interactive configuration wizard described in: #155 (comment)

I also added a few default configs needed to make videocalls work.

This is definitely something that shouldn't be enabled by default. The configuration wizard can ask the user if they want the sandbox to access the cameras.

I changed the chromium config to use wayland and not x11.

This would mean it won't work on X11 desktop environments.

I renamed "firefox.toml" to "firefox_legacy.toml" to make it look less like "the normal config" in comparison to the wayland one.

I want to make the regular one work on wayland with an x11 fallback but the issue right now is that wayland service fails then running in x11 environment. I want to add a required flag to it.

I added the GNOME portal things to firefox, needed to make them work.

I plan on adding new service to make portal integration more fine grained. The current one simply gives access to all portals. Also the fact the portal setting is located under GNOME settings is less than ideal.

@boredsquirrel
Copy link
Author

Thanks! Yes this is absolutely a dirty workaround.

I could revert some breaking changes, only focus on additions, to allow a small maintenance release to just allow some extra browsers.

But if you want to take time and make a rewrite before releasing such workarounds, all fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants