OF-1522: Ensure Jetty contexts are fully cleaned #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viv
added a commit
to viv/Openfire
that referenced
this pull request
Sep 4, 2023
Thanks to GregDThomas for spotting: IIRC it only worked on older versions of JRE/Jetty, so it's probably long redundant now. Originally created to fix https://igniterealtime.atlassian.net/browse/OF-1522 in igniterealtime#1228 (with comment "Note; we may need to revisit this come Java 9.")
viv
added a commit
to viv/Openfire
that referenced
this pull request
Sep 4, 2023
Thanks to GregDThomas for spotting: IIRC it only worked on older versions of JRE/Jetty, so it's probably long redundant now. Originally created to fix https://igniterealtime.atlassian.net/browse/OF-1522 in igniterealtime#1228 (with comment "Note; we may need to revisit this come Java 9.")
guusdk
pushed a commit
that referenced
this pull request
Sep 7, 2023
Thanks to GregDThomas for spotting: IIRC it only worked on older versions of JRE/Jetty, so it's probably long redundant now. Originally created to fix https://igniterealtime.atlassian.net/browse/OF-1522 in #1228 (with comment "Note; we may need to revisit this come Java 9.")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caused by a Jetty bug (jetty/jetty.project#1425) which has a workaround (gaohoward/jetty.project@f5b86c8) that the HttpBindManager now takes advantage of.
Note; we may need to revisit this come Java 9.