Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nodetime arm64 for linux #874

Merged
merged 11 commits into from
Mar 17, 2021
Merged

fix: Nodetime arm64 for linux #874

merged 11 commits into from
Mar 17, 2021

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 16, 2021

Adding armv8 support for linux and mac build targets

@faddat faddat mentioned this pull request Mar 16, 2021
Closed
@faddat faddat changed the title Nodetime: armv8 for linux and mac fix: Nodetime armv8 for linux and mac Mar 16, 2021
@faddat faddat changed the title fix: Nodetime armv8 for linux and mac fix: Nodetime arm64 for linux Mar 17, 2021
@faddat faddat marked this pull request as ready for review March 17, 2021 08:15
@faddat
Copy link
Contributor Author

faddat commented Mar 17, 2021 •
edited
Loading

In total, this:

  • specifies an architecture for all of the nodetime embeds, so that they get embedded for darwin-amd64, linux-amd64, and linux-arm64
    • Previously it would just look for darwin-* and linux-* and that's why linux-arm64 systems would compile successfully but then fail to scaffold an app.
  • adds the three platforms to gen-nodetime script and to package.json for nodetime (note: at this time, that means you'll want to run this on linux-arm64 as the other platforms will just download binaries)
  • still needs support for darwin-arm64 so that we can cover users of the M1 cpu from apple

Eventually, we've got to build in some kind of cross compile environment, we should be capable of building everything from source.

@ilgooz
Copy link
Member

ilgooz commented Mar 17, 2021

Excellent work, thank you @faddat!!

@ilgooz
Copy link
Member

ilgooz commented Mar 17, 2021

@fadeev can you please this on your Mac please by scaffolding an app?

@fadeev
Copy link
Contributor

fadeev commented Mar 17, 2021

Starport from hash fd2abefd165325180efe43e585ff4c0bbd84090e scaffolds a chain fine.

fadeev
fadeev approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested on macOS.

@ilgooz ilgooz merged commit 3f75241 into develop Mar 17, 2021
@ilgooz ilgooz deleted the nodetime-platform branch March 17, 2021 13:56
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@faddat @ilgooz
feat(nodetime): add arm64 linux support (ignite#874)
a782344 
* Update package.json

* Added arm64 build targets for nodetime

* Added commands to copy in arm64 build targets.  May require someone with an M1 cpu.

* added arm64 nodetime compiled binaries

* renamed for triplets

* Update package.json

remove macos arm64

* Update gen-nodetime

remove macos arm64

* arm64 binary embed

* gorelaser: rm arm64 darwin release

Co-authored-by: İlker Göktuğ ÖZTÜRK <ilkergoktugozturk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@ilgooz ilgooz ilgooz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faddat @ilgooz @fadeev