Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 873 add darwin build target #1118

Closed
wants to merge 1 commit into from
Closed

fix: 873 add darwin build target #1118

wants to merge 1 commit into from

Conversation

mangas
Copy link

@mangas mangas commented May 9, 2021 •
edited
Loading

Fixes #873

@mangas mangas mentioned this pull request May 9, 2021
Closed
@mangas mangas changed the title 873 add darwin build target fix: 873 add darwin build target May 9, 2021
@mangas mangas force-pushed the 873-add-darwin-build-target branch from d4e6f52 to 40c70be Compare May 9, 2021 22:37
@mangas mangas marked this pull request as ready for review May 9, 2021 22:54
@mangas mangas marked this pull request as draft May 9, 2021 22:54
ilgooz
ilgooz reviewed May 10, 2021
View reviewed changes
Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mangas thanks for the PR!

I recently added a comment about ARM binaries here, can you please check that?

@mangas mangas closed this May 13, 2021
@mangas mangas deleted the 873-add-darwin-build-target branch May 13, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz left review comments

@fadeev fadeev Awaiting requested review from fadeev

@lumtis lumtis Awaiting requested review from lumtis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Darwin-arm64 support for the nodetime pkg
2 participants
@mangas @ilgooz