fix(services): allow tilde and env in config validator home path (bac…

…kport #4532) (#4539)

* fix(services): allow tilde and env in config validator home path (#4532)

* fix(services): allow tilde and env in config validator home path

* updates

* up

(cherry picked from commit ff663c9)

# Conflicts:
#	ignite/config/chain/v1/validator.go
#	ignite/services/chain/chain.go
#	ignite/templates/app/files/go.mod.plush
#	ignite/templates/typed/simulation.go

* conflicts

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>

changelog.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Bug Fixe
+
+- [#4532](https://github.com/ignite/cli/pull/4532) Fix non working _shortcuts_ in validator home config
+
 ## [`v28.8.0`](https://github.com/ignite/cli/releases/tag/v28.8.0)
 
 ### Features

ignite/config/chain/v1/validator.go

@@ -36,9 +36,6 @@ type Gentx struct {
 	// Moniker is the validator's (optional) moniker.
 	Moniker string `yaml:"moniker"`
 
-	// Home is directory for config and data.
-	Home string `yaml:"home"`
-
 	// KeyringBackend is keyring's backend.
 	KeyringBackend string `yaml:"keyring-backend"`
 

ignite/services/chain/chain.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"os"
 	"path/filepath"
+	"strings"
 
 	"github.com/go-git/go-git/v5"
 	"github.com/spf13/cobra"
@@ -358,6 +359,11 @@ func (c *Chain) DefaultHome() (string, error) {
 	}
 	validator, _ := chainconfig.FirstValidator(cfg)
 	if validator.Home != "" {
+		expandedHome, err := expandHome(validator.Home)
+		if err != nil {
+			return "", err
+		}
+		validator.Home = expandedHome
 		return validator.Home, nil
 	}
 
@@ -531,3 +537,16 @@ func (c *Chain) Commands(ctx context.Context) (chaincmdrunner.Runner, error) {
 
 	return chaincmdrunner.New(ctx, cc, ccrOptions...)
 }
+
+// expandHome expands a path that may start with "~" and may contain environment variables.
+func expandHome(path string) (string, error) {
+	if strings.HasPrefix(path, "~") {
+		home, err := os.UserHomeDir()
+		if err != nil {
+			return "", err
+		}
+		// Only replace the first occurrence at the start.
+		path = home + strings.TrimPrefix(path, "~")
+	}
+	return os.ExpandEnv(path), nil
+}