Add useResetSubmitErrors hook #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
force-pushed
the
use-reset-submit-errors
branch
from
5303537 to
170421f
Compare
alanpoulain
force-pushed
the
use-reset-submit-errors
branch
from
170421f to
de73081
Compare
|
Hi! This addition looks good, however, I think we should add some tests to make sure this wouldn't break in the future. I'll try to test this soon and then merge this PR. |
|
I've rewritten the code slightly to prevent unnecessary mutators calls, as in some cases it was causing an infinite Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! First PR on this repository it seems 🙂
This hook can be useful in some cases, for instance marmelab/react-admin#5962.