Add trace errors in server binary #1314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haze518
force-pushed
the
add-trace-errors-in-binary
branch
3 times, most recently
from
62f33f5
to
0478be9
Compare
haze518
force-pushed
the
add-trace-errors-in-binary
branch
from
0478be9
to
05c792e
Compare
haze518
changed the title
numinnex
requested changes
Nov 3, 2024
| ) | ||
| .await?; | ||
| .await | ||
| .with_error(|_| format!("CONSUMER_OFFSET_HANDLER - failed to store consumer offset for stream_id: {}, topic_id: {}, partition_id: {:?}, offset: {}, session: {}", |
There was a problem hiding this comment.
since this with_error method is lazily called only on error, maybe we could try moving the command.partition_id.clone() and offset inside of there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.