Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements to logging and TUI state management #8

Merged
merged 13 commits into from
Mar 6, 2023
Merged

General improvements to logging and TUI state management #8

merged 13 commits into from
Mar 6, 2023

Conversation

ifd3f
Copy link
Owner

@ifd3f ifd3f commented Mar 6, 2023

No description provided.

@ifd3f ifd3f changed the title Create a more informative logging solution Create a more informative logging system Mar 6, 2023
@ifd3f ifd3f changed the title Create a more informative logging system General improvements to logging Mar 6, 2023
@ifd3f ifd3f self-assigned this Mar 6, 2023
@ifd3f ifd3f marked this pull request as ready for review March 6, 2023 08:35
@ifd3f ifd3f changed the title General improvements to logging General improvements to logging and TUI state management Mar 6, 2023
@ifd3f
Copy link
Owner Author

ifd3f commented Mar 6, 2023 •
edited
Loading

This works on macos, but fails on Linux, while main seems to work on Linux consistently...

EDIT: it was O_DIRECT

@ifd3f ifd3f merged commit e0f0a97 into main Mar 6, 2023
@ifd3f ifd3f added the feature New feature to add to the program itself. Does not include refactors or platform support. label Mar 6, 2023
@ifd3f ifd3f deleted the better-logging branch March 10, 2023 22:04
@ifd3f ifd3f added ux Things directly related to how the program is used and removed feature New feature to add to the program itself. Does not include refactors or platform support. labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ifd3f ifd3f

Labels
ux Things directly related to how the program is used
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ifd3f