Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deal with "GMT" time zone in iCalendar files #8506

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

jennifer-richards
Copy link
Member

A couple dozen interim meetings have been specified as the "GMT" timezone instead of "UTC". This is not handled correctly by the iCalendar renderer. This treats them as UTC. It also avoids a gross iCalendar syntax error if a timezone does not have a vtimezone file, though the resulting output will not comply with RFC 5545.

Fixes #8498

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (e33a1a8) to head (3740bf3).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8506      +/-   ##
==========================================
+ Coverage   88.81%   88.88%   +0.06%     
==========================================
  Files         312      312              
  Lines       40856    40891      +35     
==========================================
+ Hits        36288    36347      +59     
+ Misses       4568     4544      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit ed19b54 into ietf-tools:main Feb 6, 2025
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iCal file not importable
2 participants