Score-nn Evaluation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvdcoder
reviewed
Aug 10, 2021
structured_prediction_baselines/models/multilabel_classification.py
Outdated
Show resolved
Hide resolved
dhruvdcoder
requested changes
Aug 10, 2021
There was a problem hiding this comment.
If you are able to run one of the configs with evaluation on, I would suggest adding the generated .json to the tests. Since, evaluation is not a permanent thing, meaning we will only run it on best models, this will lock in the evaluation setup and protect it from breaking.
dhruvdcoder
approved these changes
Aug 13, 2021
dhruvdcoder
approved these changes
Aug 13, 2021
…aselines into feature/scorenn_evaluation
dhruvdcoder
added
configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Add generic configs with evaluation module