Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotless: automatically add trailing commas #719

Closed
sebastian-peter opened this issue Jan 31, 2024 Discussed in #318 · 0 comments · Fixed by #733
Closed

Spotless: automatically add trailing commas #719

sebastian-peter opened this issue Jan 31, 2024 Discussed in #318 · 0 comments · Fixed by #733
Assignees
Labels
code quality Code readability or efficiency is improved format Issues related to code formatting

Comments

@sebastian-peter
Copy link
Member

Discussed in #318

Originally posted by sebastian-peter August 26, 2022
My proposal is to use trailing commas. They can reduce the amount of lines changed and simplify merges with conflicting lines a lot.

This webpage gives a short introduction, and this blog post explains the benefit with merge conflicts.

spotless for Scala has an option to enforce them, no extra work required from our side: rewrite.trailingCommas.style = always

@sebastian-peter sebastian-peter added code quality Code readability or efficiency is improved format Issues related to code formatting labels Jan 31, 2024
@sebastian-peter sebastian-peter self-assigned this Feb 8, 2024
danielfeismann added a commit that referenced this issue Feb 9, 2024
# Conflicts:
#	src/main/scala/edu/ie3/simona/model/grid/RefSystem.scala
sebastian-peter added a commit that referenced this issue Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code readability or efficiency is improved format Issues related to code formatting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant