Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of PV Model #684

Closed
SimonHuette opened this issue Dec 7, 2023 · 0 comments · Fixed by #685
Closed

Fix documentation of PV Model #684

SimonHuette opened this issue Dec 7, 2023 · 0 comments · Fixed by #685
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@SimonHuette
Copy link
Contributor

I've noticed some flaws in the PV Model documentation that should be fixed. These are:

-Add description of Φ in the calculation of Sunrise Angle
-Swap out Sunrise- and Sunset Angle (sunrise angle should be negative, also matching the code)
-Fix gamma_e in Beam Radiation on Sloped Surface calculation
-Fix Incidence Angle: some terms are printed in italics
-Add description of E_dir,S in Beam Radiation on Sloped Surface calculation
-Remove description of alpha_s in Incidence Angle calculation
-Fix description of alpha_e: Should be "surface azimutz angle" instead of "sun azimuth" (also matching the code)

SimonHuette added a commit that referenced this issue Dec 13, 2023
@sebastian-peter sebastian-peter added the documentation Improvements or additions to documentation label Dec 13, 2023
danielfeismann added a commit that referenced this issue Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants