Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new scheduling protocol #650

Closed
sebastian-peter opened this issue Nov 13, 2023 · 3 comments · Fixed by #652
Closed

Introduce new scheduling protocol #650

sebastian-peter opened this issue Nov 13, 2023 · 3 comments · Fixed by #652
Assignees
@sebastian-peter
Labels
enhancement New feature or request

Comments

@sebastian-peter
Copy link
Member

The new scheduling protocol includes a bunch changes:

  • activations are scheduled without trigger, there is only a simple activation with the current tick
  • completions only include the ActorRef of the actor that is completed (no more trigger id) and possibly a new tick
@sebastian-peter sebastian-peter added the enhancement New feature or request label Nov 13, 2023
@sebastian-peter sebastian-peter self-assigned this Nov 13, 2023
@sebastian-peter sebastian-peter mentioned this issue Nov 14, 2023
Merged
@danielfeismann
Copy link
Member

Some minor side whish that may could be added here: In all_tbw we actually have some fixed timeOut for SimScheduler which is hard coded to ten minutes which could/should be supported by config to make this adaptable.

@sebastian-peter
Copy link
Member Author

@danielfeismann I believe that timeout was for debugging purposes anyways, since after that time passed, scheduler state was dumped

@danielfeismann
Copy link
Member

@sebastian-peter True, this one only logs. I miss interpreted this. There is another timeout with the same duration...

sebastian-peter added a commit that referenced this issue Nov 17, 2023
@sebastian-peter
Merge branch 'dev' into sp/#650-scheduling-protocol
806d8ae
sebastian-peter added a commit that referenced this issue Nov 19, 2023
@sebastian-peter
Merge branch 'sp/#378-simscheduler-typed' into sp/#650-scheduling-pro…
41e1bb0 
…tocol

# Conflicts:
#	src/main/scala/edu/ie3/simona/ontology/messages/SchedulerMessage.scala
#	src/main/scala/edu/ie3/simona/scheduler/ScheduleLock.scala
#	src/main/scala/edu/ie3/simona/scheduler/Scheduler.scala
#	src/main/scala/edu/ie3/simona/scheduler/TimeAdvancer.scala
#	src/main/scala/edu/ie3/simona/sim/setup/SimonaSetup.scala
#	src/test/scala/edu/ie3/simona/agent/grid/DBFSAlgorithmParticipantSpec.scala
#	src/test/scala/edu/ie3/simona/agent/grid/DBFSAlgorithmSupGridSpec.scala
#	src/test/scala/edu/ie3/simona/scheduler/ScheduleLockIT.scala
#	src/test/scala/edu/ie3/simona/scheduler/ScheduleLockSpec.scala
#	src/test/scala/edu/ie3/simona/scheduler/SchedulerSpec.scala
#	src/test/scala/edu/ie3/simona/service/primary/PrimaryServiceProxySpec.scala
sebastian-peter added a commit that referenced this issue Nov 19, 2023
@sebastian-peter
Merge branch 'sp/#651-schedule-lock' into sp/#650-scheduling-protocol
9add3a3 
# Conflicts:
#	src/main/scala/edu/ie3/simona/ontology/messages/SchedulerMessage.scala
#	src/main/scala/edu/ie3/simona/scheduler/ScheduleLock.scala
#	src/main/scala/edu/ie3/simona/scheduler/Scheduler.scala
#	src/main/scala/edu/ie3/simona/scheduler/TimeAdvancer.scala
#	src/test/scala/edu/ie3/simona/agent/grid/DBFSAlgorithmParticipantSpec.scala
#	src/test/scala/edu/ie3/simona/agent/grid/DBFSAlgorithmSupGridSpec.scala
#	src/test/scala/edu/ie3/simona/scheduler/ScheduleLockIT.scala
#	src/test/scala/edu/ie3/simona/scheduler/ScheduleLockSpec.scala
#	src/test/scala/edu/ie3/simona/scheduler/SchedulerSpec.scala
#	src/test/scala/edu/ie3/simona/service/primary/PrimaryServiceProxySpec.scala
sebastian-peter added a commit that referenced this issue Nov 19, 2023
@sebastian-peter
Merge branch 'sp/#651-schedule-lock' into sp/#650-scheduling-protocol
73754f3 
# Conflicts:
#	src/test/scala/edu/ie3/simona/scheduler/ScheduleLockIT.scala
sebastian-peter added a commit that referenced this issue Nov 20, 2023
@sebastian-peter
Merge branch 'sp/#651-schedule-lock' into sp/#650-scheduling-protocol
2d74fd8 
# Conflicts:
#	src/main/scala/edu/ie3/simona/api/ExtMessageUtils.scala
sebastian-peter added a commit that referenced this issue Nov 21, 2023
@sebastian-peter
Merge branch 'sp/#651-schedule-lock' into sp/#650-scheduling-protocol
11eafe4
sebastian-peter added a commit that referenced this issue Nov 22, 2023
@sebastian-peter
Merge branch 'dev' into sp/#650-scheduling-protocol
f63a59a
sebastian-peter added a commit that referenced this issue Nov 23, 2023
@sebastian-peter
Merge branch 'dev' into sp/#650-scheduling-protocol
72b41a7 
# Conflicts:
#	src/main/scala/edu/ie3/simona/agent/grid/GridAgentController.scala
#	src/main/scala/edu/ie3/simona/agent/participant/ParticipantAgent.scala
#	src/main/scala/edu/ie3/simona/sim/setup/SimonaStandaloneSetup.scala
#	src/test/scala/edu/ie3/simona/agent/grid/DBFSAlgorithmParticipantSpec.scala
#	src/test/scala/edu/ie3/simona/agent/participant/ParticipantAgentFundamentalsSpec.scala
#	src/test/scala/edu/ie3/simona/agent/participant/ParticipantAgentMock.scala
#	src/test/scala/edu/ie3/simona/agent/participant/WecAgentModelCalculationSpec.scala
sebastian-peter added a commit that referenced this issue Nov 28, 2023
@sebastian-peter
Merge branch 'dev' into sp/#650-scheduling-protocol
86f5207
sebastian-peter added a commit that referenced this issue Nov 28, 2023
@sebastian-peter
Merge branch 'sp/#650-scheduling-protocol' into sp/#651-scheduler-pha…
b665d4c 
…se-switch

# Conflicts:
#	src/main/scala/edu/ie3/simona/scheduler/SchedulerData.scala
danielfeismann added a commit that referenced this issue Nov 29, 2023
@danielfeismann
Merge branch 'dev' into sp/#650-scheduling-protocol
ca56c52
sebastian-peter added a commit that referenced this issue Nov 29, 2023
@sebastian-peter
Merge pull request #652 from ie3-institute/sp/#650-scheduling-protocol
8463747 
Simplified scheduling protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastian-peter sebastian-peter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplified scheduling protocol ie3-institute/simona
2 participants
@sebastian-peter @danielfeismann