Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squants for powerflow and grid #554

Closed
danielfeismann opened this issue Jun 20, 2023 · 0 comments · Fixed by #555
Closed

Squants for powerflow and grid #554

danielfeismann opened this issue Jun 20, 2023 · 0 comments · Fixed by #555
Assignees

Comments

@danielfeismann
Copy link
Member

danielfeismann commented Jun 20, 2023

grafik

          Why don't we just use squants in the fold command instead of converting back to quantities?

Originally posted by @t-ober in #491 (comment)

grafik

          We just should have an `.average` implementation for squants. Converting to quantities to average and then convert back to squants kind of defeats the purpose

Originally posted by @t-ober in #491 (comment)

grafik

          same here

Originally posted by @t-ober in #491 (comment)

@danielfeismann danielfeismann self-assigned this Jun 20, 2023
danielfeismann added a commit that referenced this issue Jul 3, 2023
danielfeismann added a commit that referenced this issue Jul 13, 2023
# Conflicts:
#	src/test/groovy/edu/ie3/simona/model/participant/BMModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/ChpModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/EvcsModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/HpModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/PvModelIT.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/PvModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/SystemParticipantTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/WecModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/load/FixedLoadModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/load/ProfileLoadModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/load/RandomLoadModelTest.groovy
danielfeismann added a commit that referenced this issue Sep 6, 2023
# Conflicts:
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSourceWrapper.scala
#	src/main/scala/edu/ie3/util/scala/quantities/ScalaNumberSystem.scala
#	src/test/groovy/edu/ie3/simona/model/participant/BMModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/HpModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/PvModelIT.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/PvModelTest.groovy
#	src/test/groovy/edu/ie3/simona/model/participant/WecModelTest.groovy
#	src/test/scala/edu/ie3/simona/agent/grid/DBFSMockGridAgents.scala
#	src/test/scala/edu/ie3/simona/service/weather/WeatherSourceWrapperSpec.scala
danielfeismann added a commit that referenced this issue Sep 27, 2023
@sebastian-peter sebastian-peter modified the milestone: Version 4.0 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants