Fix: Update Dockerfile to use correct npm script for frontend service #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an issue in the frontend Dockerfile where the `CMD` directive attempted to execute `npm run local`, a script that doesn't exist in `package.json`. This discrepancy caused the Docker container for the frontend to fail to start, hindering the setup process for developers and contributors working with Docker. Changes made: - Updated the `CMD` in the Dockerfile to use `npm run dev -- --host 0.0.0.0`, aligning it with the available scripts defined in `package.json` and ensuring the development server listens on all network interfaces within the Docker container. This adjustment facilitates access to the frontend service from the host machine or other Docker containers. Verification: - Rebuilt the Docker image for the frontend and verified that the container starts successfully and is accessible on `http://localhost:3000`. - Ensured that the frontend application functions as expected when accessed through the browser. This fix streamlines the developer experience by ensuring the Docker setup process is smooth and aligns with the project's current frontend tooling configuration.
This reverts commit 681f175.
This commit addresses an issue in the frontend Dockerfile where the `CMD` directive attempted to execute `npm run local`, a script that doesn't exist in `package.json`. This discrepancy caused the Docker container for the frontend to fail to start, hindering the setup process for developers and contributors working with Docker. Changes made: - Updated the `CMD` in the Dockerfile to use `npm run dev -- --host 0.0.0.0`, aligning it with the available scripts defined in `package.json` and ensuring the development server listens on all network interfaces within the Docker container. This adjustment facilitates access to the frontend service from the host machine or other Docker containers. Verification: - Rebuilt the Docker image for the frontend and verified that the container starts successfully and is accessible on `http://localhost:3000`. - Ensured that the frontend application functions as expected when accessed through the browser. This fix streamlines the developer experience by ensuring the Docker setup process is smooth and aligns with the project's current frontend tooling configuration.
salahlalami
requested changes
Mar 25, 2024
| CMD ["npm", "run", "dev", "--", "--host", "0.0.0.0"] |
There was a problem hiding this comment.
why is not :
CMD ["npm", "run", "dev"]
There was a problem hiding this comment.
Hi @salahlalami,
Thanks for the review! The "--", "--host", "0.0.0.0" part of the command is there to ensure that the development server listens on all network interfaces inside the Docker container. Without it, the server would only be accessible from within the container itself and wouldn't respond to requests from the host machine or other containers. This change ensures that developers can access the frontend service from their local machine when the Docker container is running.
If our Docker setup or Vite's default configuration ensures the server listens on all interfaces without explicitly setting the host, we can certainly simplify the command to just "npm", "run", "dev". I included it for compatibility and accessibility, but I'm open to updating this per your guidance.
|
@Jeetpal1 Thank you |
awesomedev82
pushed a commit
to awesomedev82/idurar-erp-crm
that referenced
this pull request
May 20, 2024
Fix: Update Dockerfile to use correct npm script for frontend service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the issue found in the frontend Dockerfile where the command
npm run localwas specified. Since there is nolocalscript inpackage.json, this command would cause the Docker container to fail to start. I have updated the Dockerfile to execute thedevscript instead, which aligns with the existing scripts defined inpackage.jsonand ensures that the Docker container for the frontend can start and run without issues.Related Issues
Steps to Test
docker-compose buildto rebuild the frontend service with the updated Dockerfile.docker-compose up.http://localhost:3000to ensure that the frontend service is running and accessible.Screenshots (if applicable)
N/A (The change is in the configuration file and does not affect the visual aspect of the application.)
Checklist
npmcommand.CMDinstruction).Fix incorrect npm script in Dockerfile for frontend).