-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When customizing a new person, Name , Last name and Number fields accept wrong and random input ( false information) #1039
Comments
Hi , i reproduced the bug with idurar version 4.0.0-beta.3, on OS: windows 10 and on a chrome browser version 123.0.6312.86 . |
Hi @Ouchi-Ranim I have made the change but I am not able to push because of authentication problem error PS C:\Users\Wajahat Ali\Desktop\OpenSource\idurar-erp-crm> git push origin wajahatFixes Please make sure you have the correct access rights |
File changed: frontend/src/pages/People/config.js Here is the fixed code please review it and let me know @Ouchi-Ranim |
Hello @aspired2001 , I was just testing your piece of code but unfortunately it doesn't work out! thank you for your effort |
Hi @Ouchi-Ranim Can you please assign this to me ? Thanks |
…name and Number fields accept wrong and random input ( false information)
Hi @Ouchi-Ranim please assign this issue to me |
Thanks for your feedback @Ouchi-Ranim I will take quick look into it |
Hello @Ouchi-Ranim, I am working on an issue within the project & I do believe that it is somehow similar to the issue you faced. |
@MehdiMsa Sure, so basically I reckoned that the issue is within the forms and how they accept invalid input, so I cloned the code on my local machine and investigated the forms file within the frontend folder, checked which fields hold that issue and used Regex to prevent invalid input, you can check the fixed code I pushed, it has more info and further details. Thank you! |
Hi Ranim, thank you for your explanation & help. It is indeed very helpful. I pushed my contribution already & the changes were made on the backend. Indeed I had to adjust the parameters in the file Config.js in the model folder. |
Hi , i reproduced the bug with idurar version 4.0.0-beta.3, on OS: windows 10 and on a chrome browser version 123.0.6312.86 . |
Bug description
The name/Last name fields accept numerical values and random values and the phone number field accept alphabetical which is misleading and produces unreliable information
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The placeholders for names only accept alphabetic characters, while the placeholder for phone numbers should exclusively allow numerical input.
Screenshots
Desktop (please complete the following information):
Additional context
I can fix the issue if permitted.
The text was updated successfully, but these errors were encountered: