Feat/ci test job #20
Merged
Feat/ci test job #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de logging service and adjusted the handlers
- Separated rocket-handler and LoggingService method, so that a http server replacement becomes easier and the architecture becomes more modular. - Added ports module, where the rocket-handler code will be moved in the next commits - Added forbid(unsafe_code) in every crate
… service, restructured keystore fairing
…separate function
schoenenberg
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
Added GitHub Actions workflow for running unit tests on multiple branches.
Description:
This pull request introduces a new GitHub Actions workflow named "test" that is triggered on pull requests targeting the
master,beta,alpha, anddevelopmentbranches. The workflow is designed to perform unit testing on the Clearing House application using Rust.Workflow Steps:
Checkout Code: The workflow starts by checking out the code from the pull request repository using the
actions/checkoutaction.Set up Rust: The Rust programming language environment is set up using the
actions-rs/toolchainaction. The stable Rust toolchain is selected for consistency and compatibility.Build and Test: Within the
clearing-house-appdirectory, the workflow performs the following tasks:cargo buildcommand while displaying verbose output.cargo testcommand with the--verboseflag for detailed output.Impact:
This workflow enhances the development process by automating the execution of unit tests for the Clearing House application across various important branches. It ensures that code changes introduced through pull requests do not introduce regressions and maintains the stability of the application.
Testing:
The workflow has been tested locally and verified to execute as expected. It successfully builds the application and runs unit tests, providing detailed feedback on any failures or errors encountered.
Notes:
The introduction of this GitHub Actions workflow contributes to the overall improvement of code quality and reliability within the Clearing House project. It aligns with best practices for continuous integration and enhances the team's ability to detect and address issues early in the development process.