-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): Bump dependencies (testcontainers & prepare for Rust Edition 2024, remove MongoDB) #121
Conversation
a93a462
to
a144d17
Compare
During the bumping of the dependencies, it was discovered that the MongoDB implementation is not working anymore. Therefore it was decided, to remove this implementation. |
"cargo fmt --check" Result:
"cargo clippy" Result:No linter warnings |
|
|
|
Clearinghouse App Build reportFormatter report ("cargo fmt --check"):No formatter warnings Linter report ("cargo clippy"):No linter warnings Test logTest log:
|
|
Clearinghouse App Build reportFormatter report ("cargo fmt --check"):Exit code: No formatter warnings Linter report ("cargo clippy"):Exit code: No linter warnings Test logExit code: 0 Test log:
|
Clearinghouse App Build reportFormatter report ("cargo fmt --check"):Exit code: 1
Linter report ("cargo clippy"):Exit code: 0 No linter warnings Test logExit code: 0 Test log:
|
|
The new |
44a85bc
to
fb32797
Compare
|
Clearinghouse App Build reportFormatter report ("cargo fmt --check"):Exit code: 1
Linter report ("cargo clippy"):Exit code: 0 No linter warnings Test logExit code: 0 Test log:
|
Clearinghouse App Build reportFormatter report ("cargo fmt --check"):Exit code: 0 No formatter warnings Linter report ("cargo clippy"):Exit code: 0 No linter warnings Test logExit code: 0 Test log:
|
|
What this PR changes/adds
Briefly describe WHAT your pr changes, which features it adds/modifies.
Updates
testcontainers
dependency and updates version constraints for other dependencies.Why it does that
Briefly state why the change was necessary.
testcontainers
had some API changes, to keep up-to-date the version was upgraded and the code appropriately changed.Cargo.toml
were updated.std::env::set_var
andstd::env::remove_var
becomesunsafe
(see this tracking issue: Tracking Issue for Rust 2024: Makestd::env::{set_var, remove_var}
unsafe rust-lang/rust#124866). To prepare for this, the calls to these functions were put intounsafe
blocks and the lint level has been changed fromforbid
todeny
, excluding these specific calls withallow
directives.Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists