- Update Tipping Contracts #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use EAS_SCHEMA as constructor arg instead of hardcoded value
- use _easSchema in modifier in TippingEAS.sol and TippingFull.sol - use OZ SafeERC20 in MultiAssetSender.sol
- use amountIn as _amount in sendTokenTo in TippingFull.sol
…sol as it is never used
- delete amount from sendNativeTo
- add temporary FeeCalculatorNew.sol used in the new tipping contract structure (TippingEASBase, TippingEASOracle, TippingCore) - remove Batchable from TippingCore.sol
1. Chainlink but no EAS 2. EAS but no Chainlink 3. Neither of the two - create empty implementation for `_afterTransfer()`` so I don't have to overwrite in all importing contracts.
- add sequencer uptime checks - refactor old files
add license
- fix input params for erc721 transferFrom
…es in one contract
…` and `AssetType.SUPPORTED_ERC20`
- reformat test file - move publicGoods mapping to FeeCalculator.sol
- fix sequencer address passing issue - add tests
- fix erc20 events
- fix wrong EAS mock contract - fix abstract keyword for Tipping.sol - temporarily ignore tests for SendToHash.test.ts
- fix tests
- fix TipMessage event amount for NFTs - fix `msgFeeUsed += fee` placement in batch sending of ERC20s - fix `paymentValue` for batch NFT sending
- start fixing ERC1155 tests
- add v2 tipping contracts
# Conflicts: # hardhat.config.ts # src/contracts/Tipping.sol # src/contracts/libs/FeeCalculator.sol # src/contracts/libs/MultiAssetSender.sol # src/contracts/mocks/MockEAS.sol # test/Tipping.test.ts
- add additional verification helper method
- add payment contract to deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple advancements to Tipping contracts.