Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: help menu for refine command #3393

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

Jyang772
Copy link
Contributor

Description

Remove reference to column number parameter in the help menu for the refine command.

Should this change go in the CHANGELOG?

  • If this is a fix, user-facing change, a compiler change, or a new paper
    implementation, I have updated CHANGELOG_NEXT.md (and potentially also
    CONTRIBUTORS.md).

@Jyang772 Jyang772 force-pushed the fix-help-menu-for-refine branch 2 times, most recently from 705da7c to 5584574 Compare September 27, 2024 22:13
Copy link
Collaborator

@mattpolzin mattpolzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! Can you drop the changes to the bootstrap files for this PR though? Those will get updated the next time a release is cut.

@Jyang772 Jyang772 force-pushed the fix-help-menu-for-refine branch from 5584574 to 5542ce1 Compare November 21, 2024 04:34
@Jyang772
Copy link
Contributor Author

This looks great, thank you! Can you drop the changes to the bootstrap files for this PR though? Those will get updated the next time a release is cut.

Thanks, I have dropped those changes.

@Jyang772 Jyang772 requested a review from mattpolzin November 21, 2024 04:38
@mattpolzin mattpolzin merged commit 263d9e8 into idris-lang:main Nov 24, 2024
22 checks passed
andrevidela pushed a commit to andrevidela/Idris2 that referenced this pull request Dec 13, 2024
* remove reference to column number parameter

* update contributors and changelog_next

* fix expected test output
andrevidela pushed a commit to andrevidela/Idris2 that referenced this pull request Dec 17, 2024
* remove reference to column number parameter

* update contributors and changelog_next

* fix expected test output
andrevidela pushed a commit to andrevidela/Idris2 that referenced this pull request Dec 24, 2024
* remove reference to column number parameter

* update contributors and changelog_next

* fix expected test output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants