feat: use blob src as default #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying mcp-ui with
|
| Latest commit: |
37b588d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://caee3775.mcp-ui.pages.dev |
| Branch Preview URL: | https://feat-render-blob-instead-src.mcp-ui.pages.dev |
idosal
reviewed
Aug 13, 2025
weizman
approved these changes
Aug 13, 2025
| }, | ||
| ); | ||
| } | ||
| if (iframeSrcBlobUrl.current && typeof window?.URL?.revokeObjectURL === 'function') { |
There was a problem hiding this comment.
If you managed to create the blob since the create function existed, it necessarily translates to the revoke function existing as well, therefore check might be redundant (nit)
|
Cool idea here. Is there a limit within any given browser to how many characters a blob URL can be for an iframe src? I imagine it's possible for rawHTML to be huge if massive script bundles and large style blocks get inlined. Hopefully, this won't be the norm, but I am curious about the upper bound edge case (if one exists). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #76 - exposed raw HTML as
srcDocmight be a security risk when used with other 3rd party scripts on the page.This PR changes the default from a raw HTML
srcDocto a Blob URL src.In embeding environments where CSP block Blob URLs - the
useSrcDocprop can be set to revert this behavior (and usesrcDocas before).