-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbiased uniformR for Integer #66
Conversation
eea2cd2
to
2924326
Compare
This looks good to me - nice work! |
For your information, I give references to alternative ways to generate random integers in a range:
Only the unbiased (exact) algorithms are probably of interest here. |
2924326
to
777da65
Compare
Only keeping the relevant output lines, I get:
Edit: updated. |
777da65
to
e2f8795
Compare
445679c
to
ef71573
Compare
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure I can say I understand why all this works, but it looks like you did the leg work and overall looks to match the paper
6f1abb9
to
274d516
Compare
Unbiased uniformR for Integer
Benchmarks: #66 (comment)