-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More efficient ranges for Word32 #65
More efficient ranges for Word32 #65
Conversation
@lehins @curiousleo are you happy for me to merge this? Here are the results for ranges using just bitmask
and here are the results when using integer multiply for Word32
I’d say it was definitely worth merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Performance boost is always nice ;)
01503a7
to
126d534
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
More efficient ranges for Word32
This can now be merged (subject to review of course). I don't think a drop in coverage of 0.1% is serious. Of course we should write more tests but in separate PRs.